Re: [PATCH 3/4] t2405: clarify test descriptions and simplify test
Show 11 quoted lines
> Le 17 janv. 2020 à 08:56, Eric Sunshine <sunshine@sunshineco.com> a écrit :
>
>> While at it, remove some unnecessary
>> leading directories such that all superproject worktrees are directly next to one
>> another in the trash directory.
>
> The unanswered questions which popped into my head when reading the
> "While at it..." include:
>
> Why is it desirable for the worktrees to live in this new location
> rather than their original locations?
I thought it was desirable because the leading directories don’t serve any purpose apart from carrying information about what they are testing, which the worktree directory itself can do instead of all of them being called "main".
>
> Is it safe to relocate the worktrees like this without losing some
> important aspect of the test?
After analyzing the test to see what was being tested, making the change and making sure the test behaved the same way, I concluded that it was.
>
> Why were the worktrees located as they were originally? Was there
> some hidden or not-so-obvious reason that we're overlooking? (I
> guess this is really the same as question #2.)
I don’t think there was a reason. The worktrees directories were structured that way since the test was introduced in df56607dff (git-common-dir: make "modules/" per-working-directory directory, 2014-11-30). Maybe one reason was for every superproject worktree to be in a directory called "main", just as every submodule is in a directory called "sub"…
I can explain more this reasoning in the commit message if necessary.
Philippe.
Philippe Blain <levraiphilippeblain@gmail.com>