Re: [PATCH 2/4] t2405: use git -C and test_commit -C instead of subshells

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jan 18, 2020, 19:50 UTC
Message-ID: <30360E66-65B3-4669-B661-237813044041@gmail.com>
In-Reply-To: <CAPig+cQgh+gmrDwSqJz1hHViBxTP6UDkuHjKTRLbackcxeQE9A@mail.gmail.com>

Hi Eric,

Show 7 quoted lines

>> -       grep "file1 updated" out
>> +       grep "file1-updated" out
> 
> Why this change? Is it because test_commit() mishandles the whitespace
> in the commit message? If so, it might deserve mention in the commit
> message of this patch. (Even better would be to fix test_commit(), if
> that is the case.)

The only reason is that I didn’t notice that test_commit accepts a <tag> argument, which defaults to <message> if unset. So when I changed the test to use test_commit and ran it I got errors from ‘git tag’ saying "file1 updated" is not a valid tag name, so I added a dash.

I’ll correct that in v2.

Thanks, Philippe.