git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH v4] Add git-grep threads param

From
VLVictor Leschuk <vleschuk@accesssoftek.com>
Date
Nov 9, 2015, 19:52 UTC
Message-ID
<6AE1604EE3EC5F4296C096518C6B77EE5D0FDABA1A@mail.accesssoftek.com>
In-Reply-To
<CA+55aFwV7c6=4mXPuB0c21rK3TSVWEw9JT-kiu35RuMzuHxoVg@mail.gmail.com>
.
> In the meantime I'd argue for just getting rid of the online_cpu's
> check, because
>  (a) I think it's actively misleading
>  (b) the threaded grep probably doesn't hurt much even on a single
> CPU, and the _potential_ upside from IO could easily dwarf the cost.
>  (c) do developers actually have single-core machines any more?
                  Linus

So as far as I understood your point at current moment would be better to leave online_cpus() check behind, keep the default threads value (and do so for other threaded programs, in separate patches of course).

After that we may focus (in future) on developing smarter heuristics for parallelity-relationed params.
Also we should specify in documentation that number of your CPUs may not the optimal value and customer should find his own best values based on other circumstances.
Correct?
Previous: Linus TorvaldsNext: Stefan Beller
Message 17 of 19 in “Add git-grep threads param”
  1. Add git-grep threads paramVictor Leschuk, Oct 27, 2015
  2. Victor LeschukNov 2, 2015
  3. Junio C HamanoNov 2, 2015
  4. Victor LeschukNov 3, 2015
  5. Junio C HamanoNov 3, 2015
  6. Jeff KingNov 4, 2015
  7. Victor LeschukNov 9, 2015
  8. Jeff KingNov 9, 2015
  9. Victor LeschukNov 9, 2015
  10. Jeff KingNov 9, 2015
  11. Victor LeschukNov 9, 2015
  12. Jeff KingNov 9, 2015
  13. Linus TorvaldsNov 9, 2015
  14. Jeff KingNov 9, 2015
  15. Victor LeschukNov 9, 2015
  16. Linus TorvaldsNov 9, 2015
  17. Victor LeschukNov 9, 2015
  18. Stefan BellerNov 9, 2015
  19. Victor LeschukNov 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.