Re: [PATCH v4] Add git-grep threads param
- From
Jeff King <peff@peff.net>
- Date
- Nov 9, 2015, 15:55 UTC
- Message-ID
- <20151109155538.GC27224@sigill.intra.peff.net>
- In-Reply-To
- <6AE1604EE3EC5F4296C096518C6B77EE5D0FDABA15@mail.accesssoftek.com>
On Mon, Nov 09, 2015 at 03:36:16AM -0800, Victor Leschuk wrote:
Show 8 quoted lines
> Yeah do also think it would be more reasonable to use "0" for > "autodetect" default value. However chat this autodetect value should > be? > > For index index-pack and pack-objects we use ncpus() for this, however > according to my tests this wouldn't an Ideal for all cases. Maybe it > should be something like ncpus()*2, > anyway before it we even used hard-coded 8 for all systems...
Why don't we leave it at 8, then? That's the conservative choice, and once we have --threads, people can easily experiment with different values and we can follow-up with a change to the default if need be.
-Peff