git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"

From
Don Zickus <dzickus@gmail.com>
Date
Aug 20, 2008, 13:10 UTC
Message-ID
<68948ca0808200610v6d81228fiabf0317ee4ae6ec5@mail.gmail.com>
In-Reply-To
<48AB0983.2050706@gmail.com>
On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote:
Show 5 quoted lines
> Marcus Griep wrote:
>> It looks like an empty line added to the end of the file.
>> Unsanitary, but ok since it comes after the last MIME
>> multipart boundary.  Junio could probably just ax the change
>> to sample.mbox from the patch before applying it.

No the change was intentional. In fact, because that extra line was not there, a bug was hidden. Adding the extra line exposed the bug and hopefully will catch any more bugs in the future with regards to the boundary code.

Show 6 quoted lines
>
> Or I could have misunderstood the intent of the change, and it
> is necessary to fully test the change, since it appears to
> operate line-by-line, an empty line at the end would be necessary
> to trigger the code path that stops mailinfo from looking for
> another boundary.
Yes, exactly.

Cheers, Don

Previous: Marcus Griep
Message 4 of 4 in “Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"”
  1. Marco CostalbaAug 19, 2008
  2. Marcus GriepAug 19, 2008
  3. Marcus GriepAug 19, 2008
  4. Don ZickusAug 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.