From: Don Zickus <dzickus@gmail.com>
Date: Wed, 20 Aug 2008 13:10:11 GMT
Subject: Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"
Message-ID: <68948ca0808200610v6d81228fiabf0317ee4ae6ec5@mail.gmail.com>
In-Reply-To: <48AB0983.2050706@gmail.com>

On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote:
> Marcus Griep wrote:
>> It looks like an empty line added to the end of the file.
>> Unsanitary, but ok since it comes after the last MIME
>> multipart boundary.  Junio could probably just ax the change
>> to sample.mbox from the patch before applying it.

No the change was intentional.  In fact, because that extra line was
not there, a bug was hidden.  Adding the extra line exposed the bug
and hopefully will catch any more bugs in the future with regards to
the boundary code.

>
> Or I could have misunderstood the intent of the change, and it
> is necessary to fully test the change, since it appears to
> operate line-by-line, an empty line at the end would be necessary
> to trigger the code path that stops mailinfo from looking for
> another boundary.

Yes, exactly.

Cheers,
Don