Re: [ANNOUNCE] git/gitweb.git repository

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Sep 4, 2007, 07:56 UTC
Message-ID: <670495.22199.qm@web31807.mail.mud.yahoo.com>
In-Reply-To: <7v8x7n7zqn.fsf@gitster.siamese.dyndns.org>

--- Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Here is my impressions on patches in:
> 
> 	git://repo.or.cz/git/gitweb.git/ next
> 
> * Removal of git_blame
> 
>   I think this makes sense; we do not need two not-so-different
>   implementations, and the other one has been the default for
>   quite some time.

My impression of the running gitweb installation at said site is that it doesn't implement 244a70e608204a515c214a11c43f3ecf7642533a. It is very easy to verify that it is not supported.

This is a data mining feature that I use regularly.

     Luben

Show 21 quoted lines

> 
> * Extra columns in blame
> 
>   I can see why some people especially with wide screen would
>   want this, and toggling the display for extra columns is also
>   a good idea.  But this makes me wonder if the single button at
>   the very top is easy to locate (maybe explain what [+] does?)
>   and easy to access (maybe have it at the top and at least at
>   the bottom as well?).
> 
> * Incremental blame
> 
>   It does not seem to break the blame, but at least from where I
>   sit accessing repo.or.cz this does not look incremental to me.
>   The entire browser session freezes until the blame page
>   displays in full.  My local installation behaves the same way.
> 
> 
> 
>   
>