[PATCH v3] filter-branch: do not consider diverging submodules a 'dirty worktree'
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 5, 2009, 18:19 UTC
- Message-ID
- <66fcb5966bce35110c880b417e160a6442256593.1233857872u.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1233857872u.git.johannes.schindelin@gmx.de>
At the end of filter-branch in a non-bare repository, the work tree is updated with "read-tree -m -u HEAD", to carry the change forward in case the current branch was rewritten. In order to avoid losing any local change during this step, filter-branch refuses to work when there are local changes in the work tree.
This "read-tree -m -u HEAD" operation does not affect what commit is checked out in a submodule (iow, it does not touch .git/HEAD in a submodule checkout), and checking if there is any local change to the submodule is not useful.
Staged submodules _are_ considered to be 'dirty', however, as the "read-tree -m -u HEAD" could result in loss of staged information otherwise.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ---
Of course I forgot the file name when I --amended the commit message, so I forgot that change...
git-filter-branch.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh index b75d0ba..86eef56 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -108,7 +108,7 @@ OPTIONS_SPEC= . git-sh-setup if [ "$(is_bare_repository)" = false ]; then - git diff-files --quiet && + git diff-files --ignore-submodules --quiet && git diff-index --cached --quiet HEAD -- || die "Cannot rewrite branch(es) with a dirty working directory." fi
-- 1.6.1.1.598.g140d5