Re: [PATCH 0/4] clone: allow configurable default for -o/--origin

From: Derrick Stolee <stolee@gmail.com>
Date: Sep 11, 2020, 19:25 UTC
Message-ID: <66e46aab-b8c5-0d9e-7a67-9a5ae6a38a93@gmail.com>
In-Reply-To: <pull.727.git.1599848727.gitgitgadget@gmail.com>

On 9/11/2020 2:25 PM, Sean Barag via GitGitGadget wrote:

Show 6 quoted lines

> Took another pass at supporting a configurable default for-o/--origin, this
> time following Junio's suggestions from a previous approach as much as
> possible [1]. Unfortunately, Johannes mentioned that --template can write
> new config values that aren't automatically merged without re-calling 
> git_config. There doesn't appear to be a way around this without rewriting
> significant amounts of init and config logic across the codebase.

Thanks for this update. I like the feature quite a bit, and all of my comments are about style and organization instead of functional issues.

> While this could have been v2 of the original patchset, it's diverged s
> drastically from the original that it likely warrants its own root thread.
> If that's not appropriate though, I'd be happy to restructure!

I think it is fine to restart the thread if the range-diff is not helpful.

Thanks, -Stolee