Re: [PATCH 0/4] clone: allow configurable default for -o/--origin
- From
Sean Barag <sean@barag.org>
- Date
- Sep 16, 2020, 03:15 UTC
- Message-ID
- <20200916031549.815253-1-sean@barag.org>
- In-Reply-To
- <CAPig+cTNjkOSRbP6sQMAhr-etXMt7ejJo3Zm2gu=nvpF00CMvw@mail.gmail.com>
Show 13 quoted lines
> A couple more observations related to a few of the subsequent tests. > This: > > template="$TRASH_DIRECTORY/template-with-config" && > > probably doesn't need $TRASH_DIRECTORY since that happens to be the > current working directory anyhow, so: > > template=template-with-config && > > should suffice (unless you had a problem doing it that way). Or you > could drop the variable altogether and use the literal name where you > need it.
I hadn't realized $TRASH_DIRECTORY was the pwd, but it makes perfect sense. Will update for v2.
Show 10 quoted lines
> Also, instead of: > > (cd clone-template-config && test "$(git config --local foo.bar)" > = "from_template") > > would probably be written these days as: > > echo from_template >expect && > git -C clone-template-config config --local foo.bar >actual && > test_cmp expect actual
Oooh `test_cmp` looks much better. Thanks for the tip!