git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: print the editor name if it fails to launch

From
Björn Gustavsson <bgustavsson@gmail.com>
Date
Dec 21, 2009, 07:54 UTC
Message-ID
<6672d0160912202354m124700dbw6e2089446d88b24@mail.gmail.com>
In-Reply-To
<7v4onlbi3q.fsf@alter.siamese.dyndns.org>
2009/12/20 Junio C Hamano <gitster@pobox.com>:
> Isn't this too elaborate?  git_editor() has already run and when it
> attempted to launch the editor it assigned to GIT_EDITOR in order to use
> it as an eval string.

I wanted to hide the details about the inner working of git_editor(), but since it is only called in one place, yes, it is too elaborate.

Show 5 quoted lines
>
>    git_editor "$TODO" ||
>    die_abort "Failed to run '${GIT_EDITOR:-your editor}'"
>
> would suffice, no?

Yes. Much better. I will rewrite my patch when I'll get home from work later today.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
Previous: Junio C Hamano
Message 4 of 4 in “rebase -i: print the editor name if it fails to launch”
  1. rebase -i: print the editor name if it fails to launchBjörn Gustavsson, Dec 20, 2009
  2. Björn GustavssonDec 20, 2009
  3. Junio C HamanoDec 20, 2009
  4. Björn GustavssonDec 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.