From: Björn Gustavsson <bgustavsson@gmail.com>
Date: Mon, 21 Dec 2009 07:54:05 GMT
Subject: Re: [PATCH] rebase -i: print the editor name if it fails to launch
Message-ID: <6672d0160912202354m124700dbw6e2089446d88b24@mail.gmail.com>
In-Reply-To: <7v4onlbi3q.fsf@alter.siamese.dyndns.org>

2009/12/20 Junio C Hamano <gitster@pobox.com>:

> Isn't this too elaborate?  git_editor() has already run and when it
> attempted to launch the editor it assigned to GIT_EDITOR in order to use
> it as an eval string.

I wanted to hide the details about the inner working of git_editor(),
but since it is only called in one place, yes, it is too elaborate.

>
>    git_editor "$TODO" ||
>    die_abort "Failed to run '${GIT_EDITOR:-your editor}'"
>
> would suffice, no?

Yes. Much better. I will rewrite my patch when I'll get home from
work later today.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB