git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] some small range-diff read_patches() fixes

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 10, 2021, 14:47 UTC
Message-ID
<65b00c6a-ef88-29c3-157b-24ad9f4d8a8c@gmail.com>
In-Reply-To
<YRGwGDvOte/o9vkd@coredump.intra.peff.net>
On 8/9/2021 6:45 PM, Jeff King wrote:
Show 8 quoted lines
> Amidst all the talk of clang4 in another thread, I noticed that Debian
> unstable recently shipped a clang-14 package. So I tried it out, and it
> does find one small cleanup. And then looking at the surrounding code
> helped me find 2 more. :)
> 
>   [1/3]: range-diff: drop useless "offset" variable from read_patches()
>   [2/3]: range-diff: handle unterminated lines in read_patches()
>   [3/3]: range-diff: use ssize_t for parsed "len" in read_patches()

I gave these a read. The code diffs are obviously correct and the explanations are well motivated. Thanks.

-Stolee
Previous: Jeff KingNext: Johannes Schindelin
Message 5 of 6 in “some small range-diff read_patches() fixes”
  1. 0/3 some small range-diff read_patches() fixesJeff King, Aug 9, 2021
  2. 1/3 range-diff: drop useless "offset" variable from read_patches()Jeff King, Aug 9, 2021
  3. 2/3 range-diff: handle unterminated lines in read_patches()Jeff King, Aug 9, 2021
  4. 3/3 range-diff: use ssize_t for parsed "len" in read_patches()Jeff King, Aug 9, 2021
  5. Derrick StoleeAug 10, 2021
  6. Johannes SchindelinAug 14, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.