From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 10 Aug 2021 14:47:38 GMT
Subject: Re: [PATCH 0/3] some small range-diff read_patches() fixes
Message-ID: <65b00c6a-ef88-29c3-157b-24ad9f4d8a8c@gmail.com>
In-Reply-To: <YRGwGDvOte/o9vkd@coredump.intra.peff.net>

On 8/9/2021 6:45 PM, Jeff King wrote:
> Amidst all the talk of clang4 in another thread, I noticed that Debian
> unstable recently shipped a clang-14 package. So I tried it out, and it
> does find one small cleanup. And then looking at the surrounding code
> helped me find 2 more. :)
> 
>   [1/3]: range-diff: drop useless "offset" variable from read_patches()
>   [2/3]: range-diff: handle unterminated lines in read_patches()
>   [3/3]: range-diff: use ssize_t for parsed "len" in read_patches()

I gave these a read. The code diffs are obviously correct and the
explanations are well motivated. Thanks.

-Stolee