git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] sha1-name: check for overflow of N in "foo^N" and "foo~N"

From
René Scharfe <l.s.r@web.de>
Date
Sep 15, 2019, 16:12 UTC
Message-ID
<651e7bdb-c2e8-e607-d78d-5292b3509a8d@web.de>
In-Reply-To
<20190915151513.GU11334@genre.crustytoothpaste.net>
Am 15.09.19 um 17:15 schrieb brian m. carlson:
> This approach seems reasonable.  I must admit some curiosity as to how
> you discovered this issue, though.  Did you have a cat assisting you in
> typing revisions?

Found it by reading the code, but I'm not sure anymore what I was actually looking for.

Would a fuzzer (or a cat) be able to catch that? The function is happily eating extra digits -- it's not crashing for me.

René
Previous: brian m. carlson
Message 4 of 4 in “rev-parse: demonstrate overflow of N for "foo^N" and "foo~N"”
  1. 1/2 rev-parse: demonstrate overflow of N for "foo^N" and "foo~N"René Scharfe, Sep 15, 2019
  2. 2/2 sha1-name: check for overflow of N in "foo^N" and "foo~N"René Scharfe, Sep 15, 2019
  3. brian m. carlsonSep 15, 2019
  4. René ScharfeSep 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.