Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)

From: Lars Schneider <larsxschneider@gmail.com>
Date: Nov 2, 2016, 17:44 UTC
Message-ID: <64EFD774-BA23-4FAB-8942-03185F447EF2@gmail.com>
In-Reply-To: <20161102170415.GA6420@tb-raspi>

On 2 Nov 2016, at 17:04, Torsten Bögershausen <tboegi@web.de> wrote:

Show 14 quoted lines

>> * ls/filter-process (2016-10-17) 14 commits
>>  (merged to 'next' on 2016-10-19 at ffd0de042c)
> 
> Some (late, as I recently got a new battery for the Mac OS 10.6 test system) 
> comments:
> t0021 failes here:
> 
> 
> Can't locate object method "flush" via package "IO::Handle" at /Users/tb/projects/git/git.next/t/t0021/rot13-filter.pl line 90.
> fatal: The remote end hung up unexpectedly
> 
> 
> perl itself is 5.10 and we use the one shipped with Mac OS.
> Why that ?

Thanks for reporting! It surprises me that flush is not available. I don't have a 10.6 system to tests. Where you able to reproduce the problem on a newer system with an older Perl, too?

@Martin: do you have a clue?

I can't debug the issue right now (only on mobile) but I will look into it on Friday!

> t0021 uses the hard-coded path:
> t0021/rot13-filter.pl (around line 345) and the nice macro
> PERL_PATH from the Makefile is fully t

Can you check the line number? Rot13-filter.pl has only 192 lines. I'll look into the PERL_PATH.

> Commenting out the different "flush" makes the test hang, and I haven't digged further.

That would be expected because the pl file writes output to a file which is checked by the calling sh script.

Thanks, Lars