Re: What's cooking in git.git (Oct 2016, #09; Mon, 31)
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Nov 2, 2016, 07:16 UTC
- Message-ID
- <20161102071646.GA5094@tb-raspi>
- In-Reply-To
- <xmqqwpgoqjct.fsf@gitster.mtv.corp.google.com>
Show 15 quoted lines
> > * tb/convert-stream-check (2016-10-27) 2 commits > - convert.c: stream and fast search for binary > - read-cache: factor out get_sha1_from_index() helper > > End-of-line conversion sometimes needs to see if the current blob > in the index has NULs and CRs to base its decision. We used to > always get a full statistics over the blob, but in many cases we > can return early when we have seen "enough" (e.g. if we see a > single NUL, the blob will be handled as binary). The codepaths > have been optimized by using streaming interface. > > The tip seems to do too much in a single commit and may be better split. > cf. <20161012134724.28287-1-tboegi@web.de> > cf. <xmqqd1il5w4e.fsf@gitster.mtv.corp.google.com>
Reviews have been done, thanks everybody.
It looks to be a good "proof of concept".
The current series is far away from being ready, so please kick it out of pu and feel free to discard.