Re: [PATCH v1 04/11] git-gui: put choose_repository::pick in a proc

From: Mark Levedahl <mlevedahl@gmail.com>
Date: May 15, 2026, 13:33 UTC
Message-ID: <6483a7a6-b1fe-4047-8c19-ab14a3284e0c@gmail.com>
In-Reply-To: <20260515110027.426-1-bootaina702@gmail.com>

On 5/15/26 7:00 AM, Aina Boot wrote:

Show 16 quoted lines

> On 5/14/26 2:33 PM, Mark Levedahl wrote:
>>  set picked 0
>> +proc pick_repo {} {
>> +	unset_gitdir_vars
>> +	load_config 1
>> +	apply_config
>> +	choose_repository::pick
>> +	set _gitdir [git rev-parse --absolute-git-dir]
>> +	set _prefix {}
>> +	set picked 1
>> +}
>> +
>>
> Here inside the proc it create vars locally, "global..." is missing.
>
> Aina

Yes, also, I missed copying the check on the return variable ::_gitdir. That proc should be:

proc pick_repo {} {
    global _gitdir picked
    unset_gitdir_vars
    load_config 1
    apply_config
    choose_repository::pick
    if {![file isdirectory $_gitdir]} {
        exit 1
    }
    set _gitdir [git rev-parse --absolute-git-dir]
    set picked 1
}

Mark