Re: [PATCH v2 09/11] git-gui: allow specifying path '.' to the browser

From: Mark Levedahl <mlevedahl@gmail.com>
Date: May 23, 2026, 15:43 UTC
Message-ID: <52331f7c-1c97-4de4-bfb6-05140ffea6b4@gmail.com>
In-Reply-To: <ae3cdc22-2f88-4222-bab7-403408373a53@kdbg.org>

On 5/23/26 10:23 AM, Johannes Sixt wrote:

Show 10 quoted lines

> Am 20.05.26 um 22:24 schrieb Mark Levedahl:
>> Invoking "git-gui browser rev ." should show the file browser for the
>> commitish rev, starting at the current directory. When the current
>> directory is the working tree root, this errors out in normalize_relpath
>> because the '.' is removed, yielding an empty list as argument to [file
>> join ...]. The browser function demands "./" in this case, so make it
>> so. (./ works on Windows as well because g4w accepts posix file
>> naming).
> I wonder why we need "./" instead of plain ".". The latter works just
> fine in my tests (on Linux).

'.' caused errors in browser::new in for me before while './' worked, but now I find both work. I'm confused, this must have been an interaction with something else in flight at the time, will revert to '.' if that passes my tests on Windows as well as it is more consistent of not adding '/' to a dirname.

Mark