Re: [PATCH 0/2] check-attr: add support to work with revisions

From: Philip Oakley <philipoakley@iee.email>
Date: Dec 6, 2022, 11:20 UTC
Message-ID: <64522fbf-c006-700f-67b5-749093d6e962@iee.email>
In-Reply-To: <20221206103736.53909-1-karthik.188@gmail.com>

Hi Karthik ,

On 06/12/2022 10:37, Karthik Nayak wrote:

Show 10 quoted lines

> Given a pathname, git-check-attr(1) will list the attributes which apply to that
> pathname by reading all relevant gitattributes files. Currently there is no way
> to specify a revision to read the gitattributes from.
>
> This is specifically useful in bare repositories wherein the gitattributes are
> only present in the git working tree but not available directly on the
> filesystem.
>
> This series aims to add a new flag `-r|--revisions` to git-check-attr(1) which
> allows us to read gitattributes from the specified revision.

Won't this also need a man page update? I don't see any changes to git/Documentation/git-check-attr.txt.

Philip

Show 18 quoted lines

>
> Karthik Nayak (2):
>   t0003: move setup for `--all` into new block
>   attr: add flag `-r|--revisions` to work with revisions
>
>  archive.c              |   2 +-
>  attr.c                 | 120 ++++++++++++++++++++++++++++-------------
>  attr.h                 |   7 ++-
>  builtin/check-attr.c   |  25 ++++-----
>  builtin/pack-objects.c |   2 +-
>  convert.c              |   2 +-
>  ll-merge.c             |   4 +-
>  pathspec.c             |   2 +-
>  t/t0003-attributes.sh  |  63 ++++++++++++++++++++--
>  userdiff.c             |   2 +-
>  ws.c                   |   2 +-
>  11 files changed, 170 insertions(+), 61 deletions(-)
>