Re: [PATCH v2 00/11] merge-ort: add basic rename detection

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 15, 2020, 14:34 UTC
Message-ID: <6448806f-791b-610a-06de-7be5650334e6@gmail.com>
In-Reply-To: <pull.812.v2.git.1607962900.gitgitgadget@gmail.com>

On 12/14/2020 11:21 AM, Elijah Newren via GitGitGadget wrote:

> This series builds on en/merge-ort-2 and adds basic rename detection to
> merge-ort.

I have now finished a full pass through this series. I find it to be well organized with a satisfying conclusion. My comments are mostly about nits. I tried to recommend some better organization, but failed to find a clear way to do so, which shows that the organization here is sound.

My only complaint is that some of the patches break compilation, so that should definitely be fixed to assist with bisects in the future (likely for bisects unrelated to this feature).

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.