Re: [PATCH] Always check the return value of `repo_read_object_file()`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2024, 22:36 UTC
Message-ID: <63f7fc07-56b3-a271-e469-e9e230c9c2ae@gmx.de>
In-Reply-To: <20240216064326.89551-1-tenglong.tl@alibaba-inc.com>

Hi,

On Fri, 16 Feb 2024, Teng Long wrote:

Show 10 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> wrote on Mon, 05 Feb 2024:
>
> Hi, when I do zh_CN l10n work for 2.44, I found some check changes like:
>
>     die(_("unable to read tree %s")
>
> in patchset, some old code for this like work is similar but with parentheses
> surrounded with the OID parameter:
>
>    die(_("unable to read tree (%s)")

FWIW I copied the error message from https://github.com/git/git/blob/v2.43.0/tree-walk.c#L103, but only now realized that it is untranslated.

> I think it's really a small nit, I don't think it's a requirement to immediately
> optimize, they're just some small printing consistency formatting issues, so make
> some small tips here.

Thank you for paying attention. I agree that it would be good to make Git's error messages consistent, even if I sadly won't be able to focus on that due to changes at my dayjob.

Ciao, Johannes