[PATCH] Always check the return value of `repo_read_object_file()`
- From
Teng Long <dyroneteng@gmail.com>
- Date
- Feb 16, 2024, 06:43 UTC
- Message-ID
- <20240216064326.89551-1-tenglong.tl@alibaba-inc.com>
- In-Reply-To
- <pull.1650.git.1707143753726.gitgitgadget@gmail.com>
Johannes Schindelin <johannes.schindelin@gmx.de> wrote on Mon, 05 Feb 2024:
Hi, when I do zh_CN l10n work for 2.44, I found some check changes like:
die(_("unable to read tree %s")in patchset, some old code for this like work is similar but with parentheses surrounded with the OID parameter:
die(_("unable to read tree (%s)")I think it's really a small nit, I don't think it's a requirement to immediately optimize, they're just some small printing consistency formatting issues, so make some small tips here.
Thanks.