git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Always check the return value of `repo_read_object_file()`

From
Teng Long <dyroneteng@gmail.com>
Date
Feb 16, 2024, 06:43 UTC
Message-ID
<20240216064326.89551-1-tenglong.tl@alibaba-inc.com>
In-Reply-To
<pull.1650.git.1707143753726.gitgitgadget@gmail.com>
Johannes Schindelin <johannes.schindelin@gmx.de> wrote on Mon, 05 Feb 2024:
Hi, when I do zh_CN l10n work for 2.44, I found some check changes like:
    die(_("unable to read tree %s")

in patchset, some old code for this like work is similar but with parentheses surrounded with the OID parameter:

   die(_("unable to read tree (%s)")

I think it's really a small nit, I don't think it's a requirement to immediately optimize, they're just some small printing consistency formatting issues, so make some small tips here.

Thanks.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 15 of 16 in “Always check the return value of `repo_read_object_file()`”
  1. Always check the return value of `repo_read_object_file()`Johannes Schindelin via GitGitGadget, Feb 5, 2024
  2. Karthik NayakFeb 5, 2024
  3. Junio C HamanoFeb 6, 2024
  4. Johannes SchindelinFeb 12, 2024
  5. Kyle LippincottFeb 6, 2024
  6. Johannes SchindelinFeb 9, 2024
  7. Junio C HamanoFeb 9, 2024
  8. Kyle LippincottFeb 9, 2024
  9. Patrick SteinhardtFeb 6, 2024
  10. Junio C HamanoFeb 6, 2024
  11. Johannes SchindelinFeb 9, 2024
  12. Patrick SteinhardtFeb 9, 2024
  13. Junio C HamanoFeb 6, 2024
  14. Johannes SchindelinFeb 12, 2024
  15. Always check the return value of `repo_read_object_file()`Teng Long, Feb 16, 2024
  16. Johannes SchindelinFeb 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.