git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pretend_sha1_file(): Change return type from int to void

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 6, 2015, 13:16 UTC
Message-ID
<632cbcf1dc9fa45ce71693a2cfae73e4@dscho.org>
In-Reply-To
<1444133704-29571-1-git-send-email-tklauser@distanz.ch>
Hi Tobias,
On 2015-10-06 14:15, Tobias Klauser wrote:
> prented_sha1_file() always returns 0 and its only callsite in
> builtin/blame.c doesn't use the return value, so change the return type
> to void.
While this commit message is technically correct, it would appear that there are some things left unsaid.
Is there a problem with the current code that is solved by not returning 0? If so, could you add it to the commit message? And in particular, change the oneline appropriately?

Ciao, Johannes

Previous: Tobias KlauserNext: Tobias Klauser
Message 2 of 12 in “pretend_sha1_file(): Change return type from int to void”
  1. pretend_sha1_file(): Change return type from int to voidTobias Klauser, Oct 6, 2015
  2. Johannes SchindelinOct 6, 2015
  3. Tobias KlauserOct 6, 2015
  4. Johannes SchindelinOct 6, 2015
  5. Tobias KlauserOct 7, 2015
  6. Junio C HamanoOct 7, 2015
  7. Stefan BellerOct 7, 2015
  8. Junio C HamanoOct 7, 2015
  9. Stefan BellerOct 7, 2015
  10. Junio C HamanoOct 7, 2015
  11. Junio C HamanoOct 7, 2015
  12. Tobias KlauserOct 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.