From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 06 Oct 2015 13:16:12 GMT
Subject: Re: [PATCH] pretend_sha1_file(): Change return type from int to void
Message-ID: <632cbcf1dc9fa45ce71693a2cfae73e4@dscho.org>
In-Reply-To: <1444133704-29571-1-git-send-email-tklauser@distanz.ch>

Hi Tobias,

On 2015-10-06 14:15, Tobias Klauser wrote:
> prented_sha1_file() always returns 0 and its only callsite in
> builtin/blame.c doesn't use the return value, so change the return type
> to void.

While this commit message is technically correct, it would appear that there are some things left unsaid.

Is there a problem with the current code that is solved by not returning 0? If so, could you add it to the commit message? And in particular, change the oneline appropriately?

Ciao,
Johannes