Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values

From: Lars Schneider <larsxschneider@gmail.com>
Date: Apr 11, 2017, 11:44 UTC
Message-ID: <62969B9F-F79E-4CBA-A343-BC8D9CDBADB6@gmail.com>
In-Reply-To: <3d351f90-af4f-1ddb-c8a0-3e7926fd722d@ramsayjones.plus.com>

Show 21 quoted lines

> On 04 Apr 2017, at 17:20, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> 
> 
> 
> On 04/04/17 00:53, David Turner wrote:
>> Unfortunately, in order to push some large repos, the http postbuffer
>> must sometimes exceed two gigabytes.  On a 64-bit system, this is OK:
>> we just malloc a larger buffer.
>> 
>> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the
>> buffer size.
>> 
>> Signed-off-by: David Turner <dturner@twosigma.com>
>> ---
>> 
>> V5 addresses comments from Torsten Boegershausen and Ramsay Jones.  Since
>> I don't have a 32-bit machine handy, it's difficult for me to check
>> for compiler warnings on 32-bit machines.  Hopefully my guess as
>> to the solution to Ramsay's issue will be correct.
> 
> Yep, this compiles without complaint.

Hi David,

You can test the 32-bit build on your machine by ...

1. Pulling this Docker image:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L58

2. Starting the Docker image:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L72

3. Running the linux32 build:
https://github.com/git/git/blob/cf11a67975b057a144618badf16dc4e3d25b9407/.travis.yml#L73

Cheers, Lars