Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values
- From
Jeff King <peff@peff.net>
- Date
- Apr 4, 2017, 02:33 UTC
- Message-ID
- <20170404023331.dqdndazmmkb24uvt@sigill.intra.peff.net>
- In-Reply-To
- <20170404013210.GD8741@aiede.mtv.corp.google.com>
On Mon, Apr 03, 2017 at 06:32:10PM -0700, Jonathan Nieder wrote:
Show 10 quoted lines
> David Turner wrote: > > > This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the > > buffer size. > > Neat. > > For completeness, it's useful to know this was added in curl 7.11.1, > which is old enough for us to be able to count on users having it (in > fact it was released >10 years ago).
We have a number of LIBCURL_VERSION_NUM checks that are older than that. I'm totally OK with declaring a 13-year old version of curl as obsolete, but we should probably consider dropping some of those ancient ifdefs. I wouldn't be surprised if some of them are buggy or even fail to compile at this point.
-Peff