git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 8/8] refs: use warning() instead of fprintf(stderr, "warning: ")

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Feb 19, 2009, 12:55 UTC
Message-ID
<628e1950be4069a614567fd4fc06aa2ce95a1004.1235047192.git.vmiklos@frugalware.org>
In-Reply-To
<cover.1235047192.git.vmiklos@frugalware.org>
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 refs.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/refs.c b/refs.c
index 6eb5f53..fd96824 100644
--- a/refs.c
+++ b/refs.c
@@ -995,7 +995,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
 
 	err = unlink(git_path("logs/%s", lock->ref_name));
 	if (err && errno != ENOENT)
-		fprintf(stderr, "warning: unlink(%s) failed: %s",
+		warning("unlink(%s) failed: %s",
 			git_path("logs/%s", lock->ref_name), strerror(errno));
 	invalidate_cached_refs();
 	unlock_ref(lock);
@@ -1437,8 +1437,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *
 				if (get_sha1_hex(rec + 41, sha1))
 					die("Log %s is corrupt.", logfile);
 				if (hashcmp(logged_sha1, sha1)) {
-					fprintf(stderr,
-						"warning: Log %s has gap after %s.\n",
+					warning("Log %s has gap after %s.",
 						logfile, show_date(date, tz, DATE_RFC2822));
 				}
 			}
@@ -1450,8 +1449,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *
 				if (get_sha1_hex(rec + 41, logged_sha1))
 					die("Log %s is corrupt.", logfile);
 				if (hashcmp(logged_sha1, sha1)) {
-					fprintf(stderr,
-						"warning: Log %s unexpectedly ended on %s.\n",
+					warning("Log %s unexpectedly ended on %s.",
 						logfile, show_date(date, tz, DATE_RFC2822));
 				}
 			}
-- 
1.6.1
Previous: Miklos Vajna
Message 19 of 19 in “Change output "error: " to "Error: " etc”
  1. 5/6 Change output "error: " to "Error: " etcJohn Tapsell, Feb 19, 2009
  2. Thomas RastFeb 19, 2009
  3. Jeff KingFeb 19, 2009
  4. http-push: using error() and warning() as appropriateMiklos Vajna, Feb 19, 2009
  5. Jeff KingFeb 19, 2009
  6. 0/8 fprintf(stderr, "warning: ") -> warning() patchesMiklos Vajna, Feb 19, 2009
  7. 1/8 builtin-apply: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  8. Jeff KingFeb 20, 2009
  9. Junio C HamanoFeb 20, 2009
  10. Miklos VajnaMar 22, 2009
  11. Junio C HamanoMar 22, 2009
  12. Miklos VajnaFeb 20, 2009
  13. 2/8 builtin-checkout: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  14. 3/8 builtin-fetch-pack: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  15. 4/8 builtin-init-db: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  16. 5/8 builtin-rm: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  17. 6/8 builtin-show-branch: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  18. 7/8 builtin-show-ref: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  19. 8/8 refs: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.