git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] Change output "error: " to "Error: " etc

From
Jeff King <peff@peff.net>
Date
Feb 19, 2009, 08:17 UTC
Message-ID
<20090219081725.GB7774@coredump.intra.peff.net>
In-Reply-To
<200902190736.49161.johnflux@gmail.com>
On Thu, Feb 19, 2009 at 07:36:49AM +0000, John Tapsell wrote:
Show 6 quoted lines
> All the error messages starting "Error: " begin with a captial E, except
> in one place.  This commit fixes this, making the output look more
> consistent.  At the moment a failed push, say, looks like:
> 
> Error: cannot lock existing info/refs
> error: failed to push some refs to 'some repository'

I think this commit message is a little misleading. True, there is only one place where "error:" appears, but it is the place that is called by almost every piece of code. So by far the majority of errors are "error: ".

http-push seems to be the odd man out. It contains one fprintf(stderr, "Error: ...") and one totally bogus error("Error: ..."), which will print "error: Error: ...". Perhaps it would be better to scan through the code and switch to using error() and warning() as appropriate.

That will make things consistent, which addresses your complaint. And then there can be a discussion if people want about whether "Error:" or "error:" is better (personally I like lowercase).

-Peff
Previous: Thomas RastNext: Miklos Vajna
Message 3 of 19 in “Change output "error: " to "Error: " etc”
  1. 5/6 Change output "error: " to "Error: " etcJohn Tapsell, Feb 19, 2009
  2. Thomas RastFeb 19, 2009
  3. Jeff KingFeb 19, 2009
  4. http-push: using error() and warning() as appropriateMiklos Vajna, Feb 19, 2009
  5. Jeff KingFeb 19, 2009
  6. 0/8 fprintf(stderr, "warning: ") -> warning() patchesMiklos Vajna, Feb 19, 2009
  7. 1/8 builtin-apply: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  8. Jeff KingFeb 20, 2009
  9. Junio C HamanoFeb 20, 2009
  10. Miklos VajnaMar 22, 2009
  11. Junio C HamanoMar 22, 2009
  12. Miklos VajnaFeb 20, 2009
  13. 2/8 builtin-checkout: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  14. 3/8 builtin-fetch-pack: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  15. 4/8 builtin-init-db: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  16. 5/8 builtin-rm: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  17. 6/8 builtin-show-branch: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  18. 7/8 builtin-show-ref: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009
  19. 8/8 refs: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Feb 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.