RE: [PATCH] Documentation/Makefile: don't re-build on 'git version' changes

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jul 3, 2021, 01:05 UTC
Message-ID: <60dfb7d11cac3_3dd220811@natae.notmuch>
In-Reply-To: <patch-1.1-911881ce19f-20210702T115617Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> Since 9a71722b4df (Doc: auto-detect changed build flags, 2019-03-17)
> we've been eagerly re-building the documentation whenever the output
> of "git version" (via the GIT-VERSION file) changed. This was never
> the intention, and was a regression on what we intended in
> 7b8a74f39cb (Documentation: Replace @@GIT_VERSION@@ in documentation,
> 2007-03-25).
> 
> So let's add an ASCIIDOC_MANVERSION variable that we exclude from
> ASCIIDOC_COMMON. The change in 9a71722b4df was only intending to catch
> cases where we e.g. switched between asciidoc and asciidoctor, not to
> undo the logic in 7b8a74f39cb and force a re-build every time our HEAD
> changed in the repository.

Once again, why do we care that the version is 2.32.0.98.gcfb60a24d6 and not 2.32.0.97.g949e814b27?

Not just in the documentation, but everywhere.

Maybe we can add a GIT_RELEASE variable that unlike GIT_VERSION it doesn't contain the precise commit. For example GIT_RELEASE = 2.33-dev.

-- 
Felipe Contreras