Re: [PATCH v2 01/10] command-list.txt: sort with "LC_ALL=C sort"
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 25, 2021, 21:22 UTC
- Message-ID
- <211025.861r483ij9.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <xmqqfssp0xge.fsf@gitster.g>
On Mon, Oct 25 2021, Junio C Hamano wrote:
Show 27 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> We should keep these files sorted in the C locale, e.g. in the C >> locale the order is: >> >> git-check-mailmap >> git-check-ref-format >> git-checkout >> >> But under en_US.UTF-8 it's: >> >> git-check-mailmap >> git-checkout >> git-check-ref-format >> >> In a subsequent commit I'll change generate-cmdlist.sh to use C sort >> order, and without this change we'd be led to believe that that change >> caused a meaningful change in the output, so let's do this as a >> separate step, right now the generate-cmdlist.sh script just uses the >> order found in this file. > > Hmph, I do not mind sorting this file bytewise like this at all, but > does the justification above still apply to this round? I had an > impression that we lose the sorting altogether in the end... > > Also, I am not sure where that "led to believe" comes from---do we > have a test that checks the output from generate-cmdlist somehow?
We end up unsorting the categories we bitwise-OR together. I.e. the CAT_* on a line like this:
{ "git-whatchanged", N_("Show logs with difference each commit introduces"), 0 | CAT_ancillaryinterrogators | CAT_complete },But we'll still sort the actual command list, and spew it out as-is in some places "git" and "help" output. So having it be unsorted or shuffled wouldn't be nice.