Re: [PATCH 5/5] config: add default aliases

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jul 2, 2021, 20:41 UTC
Message-ID: <60df79ff7643b_28bb208ed@natae.notmuch>
In-Reply-To: <xmqqr1ggpvxc.fsf@gitster.g>

Junio C Hamano wrote:

Show 8 quoted lines

> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
> 
> > I am sorry if I am coming across too strongly on this subject, but
> > I do think we are overloading alias capability and intruding on a
> > domain that should be reserved for our users, not ourselves.
> 
> Well said.  The customization feature is for helping users, and we
> shouldn't get in their way by adding unnecessary ones ourselves.

Nobody is getting in their way, and if they are unnecessary why does *everyone* have aliases?

> I wouldn't recommend us to force to our users even "co is for
> checkout" that everybody seems to have.

They are not being forced.

Show 11 quoted lines

> One thing that might (or might not) help to help users and projects
> share the same set of aliases is to make it easier to audit shared
> configuration file before inclusion.  I wonder if would help to
> introduce "include.allow" and "include.block" configuration variables
> 
>     [include] ;; or [includeIf "<condition>"]
> 	path = /usr/share/git/contrib/svnlike.alias
> 	allow = alias.*
> 
> that tells us to only pay attention to the configuration keys that
> match these 'allow' patterns when reading from the given path.

contrib is a black whole where nothing comes out of, so I would rather not doom yet another useful feature to that fate.

> But in practice, 'alias' is one of the riskier things you can set in
> the configuration file,

Why?

-- 
Felipe Contreras