RE: [PATCH] builtins + test helpers: use return instead of exit() in cmd_*
Ævar Arnfjörð Bjarmason wrote:
Show 7 quoted lines
> Change various cmd_* functions to use "return" instead of exit() to
> indicate an exit code. On Solaris with SunCC the compiler legitimately
> complains about these, since we'll e.g. skip the cleanup (e.g. closing
> fd's, erroring if we can't) in git.c's run_builtin() when we exit()
> directly like this.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Makes sense to me and it's obviously correct.
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras