From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 07 Jun 2021 17:02:11 GMT
Subject: RE: [PATCH] builtins + test helpers: use return instead of exit() in cmd_*
Message-ID: <60be5113c50a1_39c0a208e1@natae.notmuch>
In-Reply-To: <patch-1.1-61d7e6e079-20210607T111008Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> Change various cmd_* functions to use "return" instead of exit() to
> indicate an exit code. On Solaris with SunCC the compiler legitimately
> complains about these, since we'll e.g. skip the cleanup (e.g. closing
> fd's, erroring if we can't) in git.c's run_builtin() when we exit()
> directly like this.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Makes sense to me and it's obviously correct.

Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>

-- 
Felipe Contreras