git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 04/10] t/perf/fsmonitor: factor description out for readability

From
Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 26, 2020, 19:32 UTC
Message-ID
<60b5354a35faeb98d11f7f742c708ccc7cb38536.1603740773.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.772.git.1603740773.gitgitgadget@gmail.com>
From: Nipunn Koorapati <nipunn@dropbox.com>

There was much duplication here. Prepares for making changes to the description.

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
---
 t/perf/p7519-fsmonitor.sh | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
index 88b3717e2a..aa6b82d756 100755
--- a/t/perf/p7519-fsmonitor.sh
+++ b/t/perf/p7519-fsmonitor.sh
@@ -141,43 +141,45 @@ test_perf_w_drop_caches () {
 }
 
 test_fsmonitor_suite() {
-	test_perf_w_drop_caches "status (fsmonitor=$INTEGRATION_SCRIPT)" '
+	DESC="fsmonitor=$INTEGRATION_SCRIPT"
+
+	test_perf_w_drop_caches "status ($DESC)" '
 		git status
 	'
 
-	test_perf_w_drop_caches "status -uno (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "status -uno ($DESC)" '
 		git status -uno
 	'
 
-	test_perf_w_drop_caches "status -uall (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "status -uall ($DESC)" '
 		git status -uall
 	'
 
-	test_perf_w_drop_caches "diff (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff ($DESC)" '
 		git diff
 	'
 
-	test_perf_w_drop_caches "diff -- 0_files (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff -- 0_files ($DESC)" '
 		git diff -- 1_file
 	'
 
-	test_perf_w_drop_caches "diff -- 10_files (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff -- 10_files ($DESC)" '
 		git diff -- 10_files
 	'
 
-	test_perf_w_drop_caches "diff -- 100_files (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff -- 100_files ($DESC)" '
 		git diff -- 100_files
 	'
 
-	test_perf_w_drop_caches "diff -- 1000_files (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff -- 1000_files ($DESC)" '
 		git diff -- 1000_files
 	'
 
-	test_perf_w_drop_caches "diff -- 10000_files (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "diff -- 10000_files ($DESC)" '
 		git diff -- 10000_files
 	'
 
-	test_perf_w_drop_caches "add (fsmonitor=$INTEGRATION_SCRIPT)" '
+	test_perf_w_drop_caches "add ($DESC)" '
 		git add  --all
 	'
 }
-- 
gitgitgadget
Previous: Nipunn Koorapati via GitGitGadgetNext: Nipunn Koorapati via GitGitGadget
Message 12 of 13 in “Update fsmonitor perf suite to support integration comparisons”
  1. 00/10 Update fsmonitor perf suite to support integration comparisonsNipunn Koorapati via GitGitGadget, Oct 26, 2020
  2. 03/10 t/perf/fsmonitor: improve error message if typoing hook nameNipunn Koorapati via GitGitGadget, Oct 26, 2020
  3. Junio C HamanoOct 26, 2020
  4. Nipunn KoorapatiOct 26, 2020
  5. 06/10 t/perf/fsmonitor: silence initial git commitNipunn Koorapati via GitGitGadget, Oct 26, 2020
  6. 07/10 t/perf/fsmonitor: factor setup for fsmonitor into functionNipunn Koorapati via GitGitGadget, Oct 26, 2020
  7. 08/10 t/perf/fsmonitor: initialize test with git resetNipunn Koorapati via GitGitGadget, Oct 26, 2020
  8. 10/10 t/perf/fsmonitor: add benchmark for dirty statusNipunn Koorapati via GitGitGadget, Oct 26, 2020
  9. 09/10 t/perf/fsmonitor: perf comparison of multiple fsmonitor integrationsNipunn Koorapati via GitGitGadget, Oct 26, 2020
  10. 02/10 t/perf/fsmonitor: move watchman setup to one-time-repo-setupNipunn Koorapati via GitGitGadget, Oct 26, 2020
  11. 05/10 t/perf/fsmonitor: shorten DESC to basenameNipunn Koorapati via GitGitGadget, Oct 26, 2020
  12. 04/10 t/perf/fsmonitor: factor description out for readabilityNipunn Koorapati via GitGitGadget, Oct 26, 2020
  13. 01/10 t/perf/fsmonitor: separate one time repo initializationNipunn Koorapati via GitGitGadget, Oct 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.