git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/10] t/perf/fsmonitor: factor setup for fsmonitor into function

From
Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 26, 2020, 19:32 UTC
Message-ID
<409f400376dadd81335cb32e026bec1b4f0f5a26.1603740773.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.772.git.1603740773.gitgitgadget@gmail.com>
From: Nipunn Koorapati <nipunn@dropbox.com>

This prepares for it being called multiple times when testing different hooks

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
---
 t/perf/p7519-fsmonitor.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
index 970caff3d2..087f66ecc2 100755
--- a/t/perf/p7519-fsmonitor.sh
+++ b/t/perf/p7519-fsmonitor.sh
@@ -103,7 +103,7 @@ test_expect_success "one time repo setup" '
 	fi
 '
 
-test_expect_success "setup for fsmonitor" '
+setup_for_fsmonitor() {
 	# set INTEGRATION_SCRIPT depending on the environment
 	if test -n "$GIT_PERF_7519_FSMONITOR"
 	then
@@ -130,7 +130,7 @@ test_expect_success "setup for fsmonitor" '
 	cat error &&
 	[ ! -s error ] && # ensure no silent error
 	git status  # Warm caches
-'
+}
 
 test_perf_w_drop_caches () {
 	if test -n "$GIT_PERF_7519_DROP_CACHE"; then
@@ -188,6 +188,10 @@ test_fsmonitor_suite() {
 	'
 }
 
+test_expect_success "setup for fsmonitor" '
+	setup_for_fsmonitor
+'
+
 test_fsmonitor_suite
 
 test_expect_success "setup without fsmonitor" '
-- 
gitgitgadget
Previous: Nipunn Koorapati via GitGitGadgetNext: Nipunn Koorapati via GitGitGadget
Message 6 of 13 in “Update fsmonitor perf suite to support integration comparisons”
  1. 00/10 Update fsmonitor perf suite to support integration comparisonsNipunn Koorapati via GitGitGadget, Oct 26, 2020
  2. 03/10 t/perf/fsmonitor: improve error message if typoing hook nameNipunn Koorapati via GitGitGadget, Oct 26, 2020
  3. Junio C HamanoOct 26, 2020
  4. Nipunn KoorapatiOct 26, 2020
  5. 06/10 t/perf/fsmonitor: silence initial git commitNipunn Koorapati via GitGitGadget, Oct 26, 2020
  6. 07/10 t/perf/fsmonitor: factor setup for fsmonitor into functionNipunn Koorapati via GitGitGadget, Oct 26, 2020
  7. 08/10 t/perf/fsmonitor: initialize test with git resetNipunn Koorapati via GitGitGadget, Oct 26, 2020
  8. 10/10 t/perf/fsmonitor: add benchmark for dirty statusNipunn Koorapati via GitGitGadget, Oct 26, 2020
  9. 09/10 t/perf/fsmonitor: perf comparison of multiple fsmonitor integrationsNipunn Koorapati via GitGitGadget, Oct 26, 2020
  10. 02/10 t/perf/fsmonitor: move watchman setup to one-time-repo-setupNipunn Koorapati via GitGitGadget, Oct 26, 2020
  11. 05/10 t/perf/fsmonitor: shorten DESC to basenameNipunn Koorapati via GitGitGadget, Oct 26, 2020
  12. 04/10 t/perf/fsmonitor: factor description out for readabilityNipunn Koorapati via GitGitGadget, Oct 26, 2020
  13. 01/10 t/perf/fsmonitor: separate one time repo initializationNipunn Koorapati via GitGitGadget, Oct 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.