Re: [PATCH 1/2] config: improve error message for boolean config
- From
Andrew Klotz <agc.klotz@gmail.com>
- Date
- Jan 23, 2021, 23:15 UTC
- Message-ID
- <5f00282b-2e65-929a-5331-df50c4a8d8cc@gmail.com>
Thanks for the feedback,
I updated the branch and moved:
- boolean error message change out of git_config_bool_or_int to just in git_config_bool
- added die_bad_boolean instead of modifying die_bad_number.
The advantage here is we only use a bool error message when we know the value is a bool. Is this more along the lines of the suggestion?