threads / patch / 55038

patch, 2 partsRe: [PATCH 1/2] config: improve error message for boolean config

Subject: Re: [PATCH 1/2] config: improve error message for boolean config

## tl;dr

One message between Jan 23, 2021 and Jan 23, 2021. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andrew Klotz· Jan 23, 2021, 23:15 UTC · lore
Thanks for the feedback,
I updated the branch and moved:
  - boolean error message change out of git_config_bool_or_int to just 
in git_config_bool
  - added die_bad_boolean instead of modifying die_bad_number.

The advantage here is we only use a bool error message when we know the value is a bool. Is this more along the lines of the suggestion?

← back to recent threads