Re: [Janitors] value could be NULL in config parser
- From
- Govind Salinas <govind@sophiasuchtig.com>
- Date
- Feb 9, 2008, 20:11 UTC
- Message-ID
- <5d46db230802091211k304197e2i2556c82494c0852f@mail.gmail.com>
- In-Reply-To
- <200802091415.20295.chriscool@tuxfamily.org>
On 2/9/08, Christian Couder <chriscool@tuxfamily.org> wrote:
Show 26 quoted lines
> Le samedi 9 février 2008, Christian Couder a écrit :
> > Le samedi 9 février 2008, Govind Salinas a écrit :
> > > I think I got all the erroneous ones. I did
> > >
> > > find . -name "*.c" | xargs grep git_config\( | awk '{ idx = index($2,
> > > ")"); p = substr($2, 12, idx - 12); print p }' | sort | uniq -u
> >
> > It seems the "uniq -u" should be only "uniq".
> > This way, you will also get the following ones to check:
> >
> > git_default_config
> > git_diff_basic_config
> > git_log_config
> > git_pack_config
>
> I don't know awk so I cannot tell if there is something wrong with your
> script but with:
>
> find . -name "*.c" | xargs perl -ne 'print "$1\n" if (m/git_config ?
> \(([^)]*)\)/)' | sort | uniq
>
> I also get:
>
> git_imap_config
> show_all_config
>It appears only git_imap_config and git_default_config need patches. I will send them to the list.
Are any changes to the git_config_$type functions going to be made? It sounds like any change could break current configs so we are only going to stop the segfaults.
-Govind