git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Janitors] value could be NULL in config parser

From
GSGovind Salinas <govind@sophiasuchtig.com>
Date
Feb 9, 2008, 20:11 UTC
Message-ID
<5d46db230802091211k304197e2i2556c82494c0852f@mail.gmail.com>
In-Reply-To
<200802091415.20295.chriscool@tuxfamily.org>
On 2/9/08, Christian Couder <chriscool@tuxfamily.org> wrote:
Show 26 quoted lines
> Le samedi 9 février 2008, Christian Couder a écrit :
> > Le samedi 9 février 2008, Govind Salinas a écrit :
> > > I think I got all the erroneous ones.  I did
> > >
> > > find . -name "*.c" | xargs grep git_config\( | awk '{ idx = index($2,
> > > ")"); p = substr($2, 12, idx - 12); print  p }' | sort | uniq -u
> >
> > It seems the "uniq -u" should be only "uniq".
> > This way, you will also get the following ones to check:
> >
> > git_default_config
> > git_diff_basic_config
> > git_log_config
> > git_pack_config
>
> I don't know awk so I cannot tell if there is something wrong with your
> script but with:
>
> find . -name "*.c" | xargs perl -ne 'print "$1\n" if (m/git_config ?
> \(([^)]*)\)/)' | sort | uniq
>
> I also get:
>
> git_imap_config
> show_all_config
>

It appears only git_imap_config and git_default_config need patches. I will send them to the list.

Are any changes to the git_config_$type functions going to be made? It sounds like any change could break current configs so we are only going to stop the segfaults.

-Govind
Previous: Christian Couder
Message 15 of 15 in “[Janitors] value could be NULL in config parser”
  1. Junio C HamanoFeb 8, 2008
  2. archive-tar.c: guard config parser from value=NULLMiklos Vajna, Feb 8, 2008
  3. builtin-gc.c: guard config parser from value=NULLMiklos Vajna, Feb 8, 2008
  4. remote.c: guard config parser from value=NULLMiklos Vajna, Feb 8, 2008
  5. Michele BallabioFeb 8, 2008
  6. setup.c: guard config parser from value=NULLMiklos Vajna, Feb 8, 2008
  7. Michele BallabioFeb 8, 2008
  8. Miklos VajnaFeb 8, 2008
  9. Govind SalinasFeb 8, 2008
  10. Govind SalinasFeb 9, 2008
  11. Christian CouderFeb 9, 2008
  12. Junio C HamanoFeb 9, 2008
  13. Christian CouderFeb 9, 2008
  14. Christian CouderFeb 9, 2008
  15. Govind SalinasFeb 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.