Re: [PATCH] setup.c: guard config parser from value=NULL
On Friday 08 February 2008, Miklos Vajna wrote:
Show 7 quoted lines
> diff --git a/setup.c b/setup.c
> index adede16..361825f 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -346,13 +346,13 @@ int git_config_perm(const char *var, const char *value)
> {
> if (value) { ^^^^^
value is already checked here. No need to check further.
Show 15 quoted lines
> int i;
> - if (!strcmp(value, "umask"))
> + if (value && !strcmp(value, "umask"))
> return PERM_UMASK;
> - if (!strcmp(value, "group"))
> + if (value && !strcmp(value, "group"))
> return PERM_GROUP;
> - if (!strcmp(value, "all") ||
> + if (value && (!strcmp(value, "all") ||
> !strcmp(value, "world") ||
> - !strcmp(value, "everybody"))
> + !strcmp(value, "everybody")))
> return PERM_EVERYBODY;
> i = atoi(value);
> if (i > 1)
Michele Ballabio <barra_cuda@katamail.com>