Re: [PATCH 2/2] completion: add git status
- From
Thomas Braun <thomas.braun@virtuell-zuhause.de>
- Date
- Jun 1, 2016, 09:05 UTC
- Message-ID
- <5ce10133-e982-4c02-7f97-77d03231e677@virtuell-zuhause.de>
- In-Reply-To
- <20160601040722.GB18978@sigill.intra.peff.net>
Show 21 quoted lines
> Jeff King <peff@peff.net> hat am 1. Juni 2016 um 06:07 geschrieben: > > > On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote: > > > Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de> > > --- > > contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/contrib/completion/git-completion.bash > > b/contrib/completion/git-completion.bash > > index 57a0acc..96b7d86 100644 > > --- a/contrib/completion/git-completion.bash > > +++ b/contrib/completion/git-completion.bash > > @@ -1782,6 +1782,35 @@ _git_stage () > > _git_add > > } > > +_git_status () > > This patch has the same funniness as the other. Weird.
Should be fixed now.
Show 10 quoted lines
> > +{
> > + case "$cur" in
> > + --ignore-submodules=*)
> > + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}"
> > + return
> > + ;;
> > + --untracked-files=*)
> > + __gitcomp "$(__git_untracked_file_modes)" "" "${cur##--untracked-files=}"
>
> Same comment on $() here.Fixed.
Show 22 quoted lines
> > + return
> > + ;;
> > + --column=*)
> > + __gitcomp "
> > + always never auto column row plain dense nodense
> > + " "" "${cur##--column=}"
> > + return
> > + ;;
> > + --*)
> > + __gitcomp "
> > + --short --branch --porcelain --long --verbose
> > + --untracked-files= --ignore-submodules= --ignored
> > + --column= --no-column
> > + "
> > + return
> > + ;;
> > + esac
> > + __git_complete_file
> > +}
>
> The rest of it (both the overall goal, and the patch itself) look OK to
> me.Thanks, Thomas