Re: [PATCH 2/2] completion: add git status
- From
Jeff King <peff@peff.net>
- Date
- Jun 1, 2016, 04:07 UTC
- Message-ID
- <20160601040722.GB18978@sigill.intra.peff.net>
- In-Reply-To
- <b881e8b7-8364-f78b-d7ac-817850783c6e@virtuell-zuhause.de>
On Wed, Jun 01, 2016 at 01:42:18AM +0200, Thomas Braun wrote:
Show 13 quoted lines
> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de> > --- > contrib/completion/git-completion.bash | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 57a0acc..96b7d86 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1782,6 +1782,35 @@ _git_stage () > _git_add > } > +_git_status ()
This patch has the same funniness as the other. Weird.
Show 8 quoted lines
> +{
> + case "$cur" in
> + --ignore-submodules=*)
> + __gitcomp "none untracked dirty all" "" "${cur##--ignore-submodules=}"
> + return
> + ;;
> + --untracked-files=*)
> + __gitcomp "$(__git_untracked_file_modes)" "" "${cur##--untracked-files=}"Same comment on $() here.
Show 19 quoted lines
> + return
> + ;;
> + --column=*)
> + __gitcomp "
> + always never auto column row plain dense nodense
> + " "" "${cur##--column=}"
> + return
> + ;;
> + --*)
> + __gitcomp "
> + --short --branch --porcelain --long --verbose
> + --untracked-files= --ignore-submodules= --ignored
> + --column= --no-column
> + "
> + return
> + ;;
> + esac
> + __git_complete_file
> +}The rest of it (both the overall goal, and the patch itself) look OK to me.
-Peff