git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBST

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Jul 18, 2012, 22:34 UTC
Message-ID
<5c4e73c3bed1a7c9135a6229d8d66aa2c61e319a.1342649928.git.stefano.lattarini@gmail.com>
In-Reply-To
<cover.1342649928.git.stefano.lattarini@gmail.com>

The new name fits better with the macro signature, and underlines the similarities with the autoconf-provided macro AC_SUBST (which will be made even more pronounced in planned future commits).

Once again, no semantic change is intended, and indeed no change to the generated configure script is expected.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
---
 configure.ac | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 14c7960..789926f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,10 +3,10 @@
 
 ## Definitions of private macros.
 
-# GIT_CONF_APPEND_LINE(LINE)
+# GIT_CONF_SUBST(LINE)
 # --------------------------
 # Append LINE to file ${config_append}
-AC_DEFUN([GIT_CONF_APPEND_LINE],
+AC_DEFUN([GIT_CONF_SUBST],
          [echo "$1=$2" >> "${config_append}"])
 
 # GIT_ARG_SET_PATH(PROGRAM)
@@ -34,8 +34,8 @@ AC_DEFUN([GIT_CONF_APPEND_PATH],
 	if test -n "$2"; then
 		GIT_UC_PROGRAM[]_PATH=$withval
 		AC_MSG_NOTICE([Disabling use of ${PROGRAM}])
-		GIT_CONF_APPEND_LINE([NO_${PROGRAM}], [YesPlease])
-		GIT_CONF_APPEND_LINE([${PROGRAM}_PATH], [])
+		GIT_CONF_SUBST([NO_${PROGRAM}], [YesPlease])
+		GIT_CONF_SUBST([${PROGRAM}_PATH], [])
 	else
 		AC_MSG_ERROR([You cannot use git without $1])
 	fi
@@ -45,7 +45,7 @@ AC_DEFUN([GIT_CONF_APPEND_PATH],
 	else
 		GIT_UC_PROGRAM[]_PATH=$withval
 		AC_MSG_NOTICE([Setting GIT_UC_PROGRAM[]_PATH to $withval])
-		GIT_CONF_APPEND_LINE([${PROGRAM}_PATH], [$withval])
+		GIT_CONF_SUBST([${PROGRAM}_PATH], [$withval])
 	fi
     fi
     m4_popdef([GIT_UC_PROGRAM])])
@@ -67,7 +67,7 @@ AC_DEFUN([GIT_PARSE_WITH],
 	NO_[]GIT_UC_PACKAGE=
 	GIT_UC_PACKAGE[]DIR=$withval
 	AC_MSG_NOTICE([Setting GIT_UC_PACKAGE[]DIR to $withval])
-	GIT_CONF_APPEND_LINE([${PACKAGE}DIR], [$withval])
+	GIT_CONF_SUBST([${PACKAGE}DIR], [$withval])
     fi
     m4_popdef([GIT_UC_PACKAGE])])
 
@@ -87,7 +87,7 @@ AC_DEFUN([GIT_PARSE_WITH_SET_MAKE_VAR],
 		     [a value for $1 ($2).  Maybe you do...?])
   fi
   AC_MSG_NOTICE([Setting $2 to $withval])
-  GIT_CONF_APPEND_LINE([$2], [$withval])
+  GIT_CONF_SUBST([$2], [$withval])
  fi)])# GIT_PARSE_WITH_SET_MAKE_VAR
 
 #
@@ -150,7 +150,7 @@ AC_ARG_WITH([sane-tool-path],
   else
     AC_MSG_NOTICE([Setting SANE_TOOL_PATH to '$withval'])
   fi
-  GIT_CONF_APPEND_LINE([SANE_TOOL_PATH], [$withval])],
+  GIT_CONF_SUBST([SANE_TOOL_PATH], [$withval])],
   [# If the "--with-sane-tool-path" option was not given, don't touch
    # SANE_TOOL_PATH here, but let defaults in Makefile take care of it.
    # This should minimize spurious differences in the behaviour of the
@@ -169,7 +169,7 @@ AC_ARG_WITH([lib],
   else
 	lib=$withval
 	AC_MSG_NOTICE([Setting lib to '$lib'])
-	GIT_CONF_APPEND_LINE([lib], [$withval])
+	GIT_CONF_SUBST([lib], [$withval])
   fi])
 
 if test -z "$lib"; then
@@ -205,7 +205,7 @@ AC_ARG_ENABLE([jsmin],
 [
   JSMIN=$enableval;
   AC_MSG_NOTICE([Setting JSMIN to '$JSMIN' to enable JavaScript minifying])
-  GIT_CONF_APPEND_LINE([JSMIN], [$enableval]);
+  GIT_CONF_SUBST([JSMIN], [$enableval]);
 ])
 
 # Define option to enable CSS minification
@@ -215,7 +215,7 @@ AC_ARG_ENABLE([cssmin],
 [
   CSSMIN=$enableval;
   AC_MSG_NOTICE([Setting CSSMIN to '$CSSMIN' to enable CSS minifying])
-  GIT_CONF_APPEND_LINE([CSSMIN], [$enableval]);
+  GIT_CONF_SUBST([CSSMIN], [$enableval]);
 ])
 
 ## Site configuration (override autodetection)
@@ -256,7 +256,7 @@ AS_HELP_STRING([],           [ARG can be also prefix for libpcre library and hea
 	USE_LIBPCRE=YesPlease
 	LIBPCREDIR=$withval
 	AC_MSG_NOTICE([Setting LIBPCREDIR to $withval])
-	GIT_CONF_APPEND_LINE([LIBPCREDIR], [$withval])
+	GIT_CONF_SUBST([LIBPCREDIR], [$withval])
     fi)
 #
 # Define NO_CURL if you do not have curl installed.  git-http-pull and
-- 
1.7.10.2.1067.g553d16e
Previous: Stefano LattariniNext: Junio C Hamano
Message 3 of 31 in “build system: support automatic reconfiguration for autotools user”
  1. 0/7 build system: support automatic reconfiguration for autotools userStefano Lattarini, Jul 18, 2012
  2. 1/7 autoconf: GIT_CONF_APPEND_LINE: change signatureStefano Lattarini, Jul 18, 2012
  3. 2/7 autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBSTStefano Lattarini, Jul 18, 2012
  4. Junio C HamanoJul 19, 2012
  5. Stefano LattariniJul 19, 2012
  6. 3/7 autoconf: remove some redundant shell indirectionsStefano Lattarini, Jul 18, 2012
  7. Junio C HamanoJul 19, 2012
  8. Stefano LattariniJul 19, 2012
  9. Junio C HamanoJul 19, 2012
  10. Stefano LattariniJul 19, 2012
  11. 4/7 autoconf: remove few redundant semicolonsStefano Lattarini, Jul 18, 2012
  12. 5/7 autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append'Stefano Lattarini, Jul 18, 2012
  13. 6/7 build: "make clean" should not remove configure-generated filesStefano Lattarini, Jul 18, 2012
  14. Matthieu MoyJul 19, 2012
  15. Stefano LattariniJul 19, 2012
  16. Matthieu MoyJul 19, 2012
  17. Stefano LattariniJul 19, 2012
  18. Junio C HamanoJul 19, 2012
  19. 7/7 build: reconfigure automatically if configure.ac changesStefano Lattarini, Jul 18, 2012
  20. Junio C HamanoJul 19, 2012
  21. 0/7 build system: support automatic reconfiguration for autotools userStefano Lattarini, Jul 19, 2012
  22. 1/7 autoconf: GIT_CONF_APPEND_LINE: change signatureStefano Lattarini, Jul 19, 2012
  23. 2/7 autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBSTStefano Lattarini, Jul 19, 2012
  24. 3/7 autoconf: remove some redundant shell indirectionsStefano Lattarini, Jul 19, 2012
  25. 4/7 autoconf: remove few redundant semicolonsStefano Lattarini, Jul 19, 2012
  26. 5/7 autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append'Stefano Lattarini, Jul 19, 2012
  27. 6/7 build: "make clean" should not remove configure-generated filesStefano Lattarini, Jul 19, 2012
  28. Stefano LattariniJul 23, 2012
  29. Junio C HamanoJul 23, 2012
  30. 7/7 build: reconfigure automatically if configure.ac changesStefano Lattarini, Jul 19, 2012
  31. Stefano LattariniJul 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.