Re: [PATCH 2/7] autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBST
On 07/19/2012 02:13 AM, Junio C Hamano wrote:
Show 29 quoted lines
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
>
>> The new name fits better with the macro signature, and underlines the
>> similarities with the autoconf-provided macro AC_SUBST (which will be
>> made even more pronounced in planned future commits).
>>
>> Once again, no semantic change is intended, and indeed no change to the
>> generated configure script is expected.
>>
>> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
>> ---
>> configure.ac | 24 ++++++++++++------------
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 14c7960..789926f 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -3,10 +3,10 @@
>>
>> ## Definitions of private macros.
>>
>> -# GIT_CONF_APPEND_LINE(LINE)
>> +# GIT_CONF_SUBST(LINE)
>
> I see that [PATCH 1/7] needs to be updated so that it describes the
> new two-argument form of GIT_CONF_APPEND_LINE(VAR, VAL), and this
> patch needs to be updated for GIT_CONF_SUBST() with the same.
>
Oops, you're right. I will fix that in the re-roll.
Show 8 quoted lines
>> # --------------------------
>> # Append LINE to file ${config_append}
>
> Also the description definitely wants to be updated; it is no longer
> LINEness that matters.
>
> Other than that, 1 & 2 looked very nice and sensible.
>Stefano Lattarini <stefano.lattarini@gmail.com>