Re: What's cooking in git.git (Sep 2011, #04; Mon, 12)

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Sep 13, 2011, 16:22 UTC
Message-ID: <5XXEFw0WjtXKd9dpXSxpkskCcgVyG9Db1_zzVSEBNey-kpXSBbmQfYaxZ2Szg6Pbck6hZZTQ5hHzBwG4rhKYXshrd-mveEFLPZ9W0V8P_lw@cipher.nrlssc.navy.mil>
In-Reply-To: <20110913160520.GA28634@sigill.intra.peff.net>

On 09/13/2011 11:05 AM, Jeff King wrote:

Show 11 quoted lines

> On Tue, Sep 13, 2011 at 10:15:15AM -0500, Brandon Casey wrote:
> 
>> ...and I see there is already an fnmatch_icase() in dir.c which adds
>> FNM_CASEFOLD when the global var ignore_case is set.  So, maybe it's as
>> easy as:
>> [...]
>> -               return (fnmatch(pattern, basename, 0) == 0);
>> +               return (fnmatch_icase(pattern, basename, 0) == 0);
> 
> OK, wow. That's exactly the level of easy I was hoping for. Do you want
> to roll that up into a patch with some tests?

I haven't even tested that it runs. :) No, I was hoping someone who was more interested would finish it, and maybe even test on an affected system.

-Brandon