Re: What's cooking in git.git (Sep 2011, #04; Mon, 12)

From: Jeff King <peff@peff.net>
Date: Sep 13, 2011, 16:05 UTC
Message-ID: <20110913160520.GA28634@sigill.intra.peff.net>
In-Reply-To: <DJ8J88If0KG_BPR1BK-feQRQ5yjv1AIYHW3sMosJzbrjCLKCIJABAFuSAH9IrkEl-y3-8mIKsysdqADcV6A7C7f4UuM9aZNpztbz_L9pXXw@cipher.nrlssc.navy.mil>

On Tue, Sep 13, 2011 at 10:15:15AM -0500, Brandon Casey wrote:

Show 6 quoted lines

> ...and I see there is already an fnmatch_icase() in dir.c which adds
> FNM_CASEFOLD when the global var ignore_case is set.  So, maybe it's as
> easy as:
> [...]
> -               return (fnmatch(pattern, basename, 0) == 0);
> +               return (fnmatch_icase(pattern, basename, 0) == 0);

OK, wow. That's exactly the level of easy I was hoping for. Do you want to roll that up into a patch with some tests?

-Peff