git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 1/2] convert: refactor conversion driver config parsing

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jul 8, 2018, 18:35 UTC
Message-ID
<5D87BD79-983C-45D8-A284-1CFC65FBDDB8@gmail.com>
In-Reply-To
<20180708183036.29459-2-larsxschneider@gmail.com>
Show 40 quoted lines
> On Jul 8, 2018, at 8:30 PM, larsxschneider@gmail.com wrote:
> 
> From: Lars Schneider <larsxschneider@gmail.com>
> 
> Refactor conversion driver config parsing to ease the parsing of new
> configs in a subsequent patch.
> 
> No functional change intended.
> 
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> convert.c | 64 +++++++++++++++++++++++++++----------------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/convert.c b/convert.c
> index 64d0d30e08..949bc783e4 100644
> --- a/convert.c
> +++ b/convert.c
> @@ -1003,43 +1003,43 @@ static int read_convert_config(const char *var, const char *value, void *cb)
> 	int namelen;
> 	struct convert_driver *drv;
> 
> ...
> 
> -	/*
> -	 * filter.<name>.smudge and filter.<name>.clean specifies
> -	 * the command line:
> -	 *
> -	 *	command-line
> -	 *
> -	 * The command-line will not be interpolated in any way.
> -	 */
> +		/*
> +		 * filter.<name>.smudge and filter.<name>.clean specifies
> +		 * the command line:
> +		 *
> +		 *	command-line
> +		 *
> +		 * The command-line will not be interpolated in any way.
> +		 */

I stumbled over this comment introduced in aa4ed402c9 ("Add 'filter' attribute and external filter driver definition.", 2007-04-21).

Is the middle "command-line" intentional?
- Lars
Previous: larsxschneider@gmail.comNext: Junio C Hamano
Message 3 of 8 in “convert: add alias support for 'working-tree-encoding' attributes”
  1. 0/2 convert: add alias support for 'working-tree-encoding' attributeslarsxschneider@gmail.com, Jul 8, 2018
  2. 1/2 convert: refactor conversion driver config parsinglarsxschneider@gmail.com, Jul 8, 2018
  3. Lars SchneiderJul 8, 2018
  4. Junio C HamanoJul 9, 2018
  5. Junio C HamanoJul 10, 2018
  6. 2/2 convert: add alias support for 'working-tree-encoding' attributeslarsxschneider@gmail.com, Jul 8, 2018
  7. Lars SchneiderJul 8, 2018
  8. Junio C HamanoJul 10, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.