From: Lars Schneider <larsxschneider@gmail.com>
Date: Sun, 08 Jul 2018 18:35:50 GMT
Subject: Re: [PATCH v1 1/2] convert: refactor conversion driver config parsing
Message-ID: <5D87BD79-983C-45D8-A284-1CFC65FBDDB8@gmail.com>
In-Reply-To: <20180708183036.29459-2-larsxschneider@gmail.com>



> On Jul 8, 2018, at 8:30 PM, larsxschneider@gmail.com wrote:
> 
> From: Lars Schneider <larsxschneider@gmail.com>
> 
> Refactor conversion driver config parsing to ease the parsing of new
> configs in a subsequent patch.
> 
> No functional change intended.
> 
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> convert.c | 64 +++++++++++++++++++++++++++----------------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/convert.c b/convert.c
> index 64d0d30e08..949bc783e4 100644
> --- a/convert.c
> +++ b/convert.c
> @@ -1003,43 +1003,43 @@ static int read_convert_config(const char *var, const char *value, void *cb)
> 	int namelen;
> 	struct convert_driver *drv;
> 
> ...
> 
> -	/*
> -	 * filter.<name>.smudge and filter.<name>.clean specifies
> -	 * the command line:
> -	 *
> -	 *	command-line
> -	 *
> -	 * The command-line will not be interpolated in any way.
> -	 */
> +		/*
> +		 * filter.<name>.smudge and filter.<name>.clean specifies
> +		 * the command line:
> +		 *
> +		 *	command-line
> +		 *
> +		 * The command-line will not be interpolated in any way.
> +		 */

I stumbled over this comment introduced in aa4ed402c9 
("Add 'filter' attribute and external filter driver definition.", 2007-04-21).

Is the middle "command-line" intentional?

- Lars