Re: [PATCH] http: fix some printf format warnings on 32-bit builds
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Nov 11, 2015, 08:02 UTC
- Message-ID
- <5C9FC321-5B5E-47E6-9BCE-6CDAA41D6E54@gmail.com>
- In-Reply-To
- <CAGZ79kb1pDhcP+hN9+C0xK-VYKxfnhvj6a2Len6kOWgmv4+fmQ@mail.gmail.com>
On 11 Nov 2015, at 03:00, Stefan Beller <sbeller@google.com> wrote:
Show 27 quoted lines
> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones
>> <ramsay@ramsayjones.plus.com> wrote:
>>> Commit f8117f55 ("http: use off_t to store partial file size",
>>> 02-11-2015) changed the type of some variables from long to off_t.
>>> The 32-bit build, which enables the large filesystem interface
>>> (_FILE_OFFSET_BITS == 64), defines the off_t type as a 64-bit
>>> integer, whereas long is a 32-bit integer. This results in a couple
>>> of printf format warnings.
>>>
>>> In order to suppress the warnings, change the format specifier to use
>>> the PRIuMAX macro and cast the off_t argument to uintmax_t. (See also
>>> the http_opt_request_remainder() function, which uses the same
>>> solution).
>>
>> I just ran across the problem when building 'next' on my Mac and was
>> about to investigate, so am happy to find that the work has already
>> been done. Thanks.
>>
>> My machine is 64-bit, though, so perhaps it's misleading to
>> characterize this as a fix for 32-bit builds. In particular, off_t is
>> 'long long' on this machine, so it complains about the "long" format
>> specifier.
>
> +Lars
>
> I wonder if 32 bit compilation can be part of travis.Unfortunately no. All their machines are 64-bit [1] and they have "no immediate plans to add this feature" [2]. However, we could the following build configuration on a 64-bit machine:
export CFLAGS="-m32" export LDFLAGS="-m32"
I think then we could catch these kind of warnings. Do you see a downside with this approach?
- Lars
[1] http://docs.travis-ci.com/user/ci-environment/ [2] https://github.com/travis-ci/travis-ci/issues/986