git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

From
Jeff King <peff@peff.net>
Date
Nov 11, 2015, 20:54 UTC
Message-ID
<20151111205405.GA31494@sigill.intra.peff.net>
In-Reply-To
<CAPig+cS54yTsZ8NWjyh6kj6nXy966EkYPHh_sjMbMcDGemnFuA@mail.gmail.com>
On Wed, Nov 11, 2015 at 03:31:01PM -0500, Eric Sunshine wrote:
Show 5 quoted lines
> The fact that 'long' and 'long long' happen to be the same size (in
> this case) is immaterial. What is important is that the code is just
> wrong to be using the "%l" specifier for 'long' when the actual
> datatype is 'long long' (which is what 'off_t' is under-the-hood in
> this case).

Right. We cannot assume anything about what is in off_t, and should be casting to uintmax_t. So the patch is right, but I agree the commit message could be better. I started to hack it up myself, but I didn't want to put too many words in Ramsay's mouth. Do you mind resending with an updated commit message?

Thanks (and thank you in the first place for finding and fixing the breakage I introduced in f8117f55).

-Peff
Previous: Eric SunshineNext: Ramsay Jones
Message 15 of 19 in “http: fix some printf format warnings on 32-bit builds”
  1. http: fix some printf format warnings on 32-bit buildsRamsay Jones, Nov 11, 2015
  2. Eric SunshineNov 11, 2015
  3. Stefan BellerNov 11, 2015
  4. Lars SchneiderNov 11, 2015
  5. Stefan BellerNov 11, 2015
  6. Ramsay JonesNov 11, 2015
  7. Lars SchneiderNov 13, 2015
  8. Eric SunshineNov 13, 2015
  9. Torsten BögershausenNov 13, 2015
  10. Lars SchneiderNov 13, 2015
  11. Ramsay JonesNov 13, 2015
  12. Lars SchneiderNov 14, 2015
  13. Ramsay JonesNov 11, 2015
  14. Eric SunshineNov 11, 2015
  15. Jeff KingNov 11, 2015
  16. Ramsay JonesNov 11, 2015
  17. Torsten BögershausenNov 12, 2015
  18. Ramsay JonesNov 12, 2015
  19. Andreas SchwabNov 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.